fix(rules): PR #4050 follow-up — math inconsistency + persona/name attribution#4051
Merged
AceHack merged 2 commits intoMay 17, 2026
Conversation
…tribution on rule surface Addresses 2 Copilot review findings on PR #4050 that landed post-merge: 1. **Math inconsistency** (line 316): table listed 10 pre-empt #5 rows but text said "8 cycles" and artifact categories summed to 10 vs "12 artifacts claimed earlier." - Fixed: 10 cycles explicitly labeled in table; intro clarifies "12 PR-content changes (10 substrate files + 1 BACKLOG.md regen + 1 worked-example memo)" with the 10 cycle artifacts as a distinct count. 2. **Persona/name attribution on rule surface** (line 282): factory convention keeps names out of reusable current-state rules unless it's a history surface or roster-mapping carve-out. - Fixed: refactored 'Lior' → 'antigravity peer-agent loop'; 'peer-Otto' → 'peer autonomous-loop instance'; 'Otto-CLI' → 'the autonomous-loop'; 'Aaron' → 'the human maintainer'. - Section header renamed: 'Sustained-Lior' → 'Sustained-named-dep'. Both findings were valid and substrate-honestly fixed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates a factory rule document to correct an internal cycle/artifact count inconsistency from PR #4050 and to remove named attribution from a current-state rules surface.
Changes:
- Renames the empirical-anchor section header to avoid named attribution (“Sustained-named-dep…”).
- Reconciles the pre-empt-at-#5 cycle count by labeling cycles 1–10 and updating the “Pattern observed” summary.
- Reframes the “12 artifacts” claim into “12 PR-content changes” with a breakdown of which changes were produced by the pre-empt cadence.
…larify cycle-vs-file math 2 valid Copilot findings on PR #4051: 1. line 282: regex pattern `gemini.*Lior|lior.*loop` still embedded the persona name. Replaced with a reference to the canary rule (which documents the actual pattern locally) — keeps this rule generic. 2. line 284: '10 new substrate files' conflicted with the pre-empt artifact list (cycle 4 was an edit, cycle 9 was a bus envelope, cycle 10 was a PR body file). Rewrote to: - 'in PR #4046: 10 new substrate files + 1 BACKLOG.md regeneration' (the actual file count) - 'Of the 10 new files, 7 were authored during the 10 pre-empt cycles; the cycle-4 row-update merged into cycle-2's diff; the other 3 (carry-over shard + 2 substantive-tick artifacts) were authored outside pre-empt cadence' - 'Cycle 9 produced a bus envelope (not in-repo); cycle 10 produced a PR body file (not committed)' This sharpens the math without changing the empirical claims. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
AceHack
deleted the
otto/fix-pr-4050-followup-math-and-persona-attribution-2026-05-17
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 2 valid Copilot review findings on PR #4050 that landed post-merge (Copilot reviewed after auto-merge had already fired).
Findings fixed
Math inconsistency (line 316): table listed 10 pre-empt Round 29 — CI pipeline + three-way parity install + factory-improvement surge #5 rows but text said "8 cycles" and artifact categories summed to 10 vs "12 artifacts claimed earlier."
cycle 1throughcycle 10); intro clarifies "12 PR-content changes (10 substrate files + 1 BACKLOG.md regen + 1 worked-example memo)" with the 10 cycle artifacts as a distinct count.Persona/name attribution on rule surface (line 282): factory convention keeps names out of reusable current-state rules.
Lior→antigravity peer-agent loop matching \gemini.*Lior|lior.*loop`;peer-Otto→peer autonomous-loop instance;Otto-CLI→the autonomous-loop;Aaron→the human maintainer`.Sustained-Lior→Sustained-named-dep.Substrate-honest framing
Both findings were valid. The original section landed via the rule's own forced-#6 discipline (PR #4050 was itself a rule-edit pre-empt). This follow-up shows the discipline continuing to operate correctly — review findings on a merged PR get a follow-up PR, not narrative-only resolution.
Test plan
🤖 Generated with Claude Code